Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (setup_reader): parse arguments when setuptools.setup() is used (#1761) #1764

Merged

Conversation

@finswimmer
Copy link
Member

finswimmer commented Dec 18, 2019

At the moment the parser expect that the setup method in setup.py is called with setup() only and will fail if setuptools.setup() is used instead. This PR fixes it.

Fixes: #1761

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
…lled by `setuptools.setup()`
@finswimmer finswimmer requested a review from python-poetry/core Dec 18, 2019
finswimmer77@gmail.com added 2 commits Dec 18, 2019
@sdispater sdispater merged commit 945ca1d into python-poetry:master Dec 20, 2019
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
shenek added a commit to shenek/poetry that referenced this pull request Dec 31, 2019
…ython-poetry#1761) (python-poetry#1764)

* fix (setup_reader): in `setup.py` the `setup()` method can also be called by `setuptools.setup()`

* fix (setup_reader): make black happy

* fix (setup_reader): skip test for python <3.4
@finswimmer finswimmer mentioned this pull request Jan 10, 2020
0 of 2 tasks complete
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.