Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle spaces in command executable #1774

Merged
merged 1 commit into from Dec 24, 2019

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Dec 20, 2019

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Fix #1747

use list_to_shell_command to wrap executable.

@frostming frostming changed the title Fix command args handling Correctly handle spaces in command executable Dec 20, 2019
@finswimmer finswimmer added the Bug label Dec 23, 2019
Copy link
Member

@finswimmer finswimmer left a comment

Thanks a lot for your contribution! 🍬

@sdispater sdispater merged commit 1c45012 into python-poetry:master Dec 24, 2019
16 checks passed
@frostming frostming deleted the bugfix/1747 branch Dec 25, 2019
shenek pushed a commit to shenek/poetry that referenced this issue Dec 31, 2019
@absassi
Copy link

@absassi absassi commented Jan 12, 2020

This also fixes #1479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants