Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle spaces in command executable #1774

Merged
merged 1 commit into from Dec 24, 2019

Conversation

@frostming
Copy link
Contributor

frostming commented Dec 20, 2019

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Fix #1747

use list_to_shell_command to wrap executable.

@frostming frostming force-pushed the frostming:bugfix/1747 branch from cbe4a0e to b506d91 Dec 20, 2019
@frostming frostming changed the title Fix command args handling Correctly handle spaces in command executable Dec 20, 2019
@finswimmer finswimmer added the Bug label Dec 23, 2019
Copy link
Member

finswimmer left a comment

Thanks a lot for your contribution! 🍬

@sdispater sdispater merged commit 1c45012 into python-poetry:master Dec 24, 2019
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
@frostming frostming deleted the frostming:bugfix/1747 branch Dec 25, 2019
shenek added a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
@absassi

This comment has been minimized.

Copy link

absassi commented Jan 12, 2020

This also fixes #1479.

@finswimmer finswimmer mentioned this pull request Jan 12, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.