Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password management #1788

Merged
merged 1 commit into from Dec 26, 2019
Merged

Improve password management #1788

merged 1 commit into from Dec 26, 2019

Conversation

@sdispater
Copy link
Member

sdispater commented Dec 23, 2019

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR is a refactoring of the password management of Poetry. This alleviates some of the keyring shortcomings and delays the import of keyring to only
when it's needed to avoid the CLI hanging because of it (see #1779).

Fixes #1779
Fixes #1719
Fixes #1565
Fixes #1335

@sdispater sdispater requested a review from python-poetry/core Dec 23, 2019
@K900

This comment has been minimized.

Copy link
Contributor

K900 commented Dec 25, 2019

Would be really nice to see the keyring dependency bumped to something like >=19.0 on Python 3. It makes source built Poetry not run on Arch...

@sdispater sdispater merged commit 299a885 into master Dec 26, 2019
32 checks passed
32 checks passed
Linting
Details
Linting
Details
Linux (2.7)
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.7)
Details
Linux (3.8)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.7)
Details
Windows (3.8)
Details
Windows (3.8)
Details
@sdispater sdispater deleted the improve-password-management branch Dec 26, 2019
@Ivoz

This comment has been minimized.

Copy link

Ivoz commented Dec 27, 2019

Unfortunately keyring 19.0 drops python 2.7, so you'd have to figure out what you want to do about that

shenek added a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.