Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dependency if not needed #1789

Merged
merged 1 commit into from Dec 26, 2019
Merged

Conversation

@frostming
Copy link
Contributor

frostming commented Dec 24, 2019

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Closes #1782
This bug affects the basic dev flow and bites me often. When a dependency is marked as required on older Python versions, it should be ignored if the parent constraint has no overlap with it.

@frostming frostming force-pushed the frostming:bugfix/1782 branch from 685f9a7 to df86339 Dec 24, 2019
@frostming

This comment has been minimized.

Copy link
Contributor Author

frostming commented Dec 24, 2019

As a quick view of the bug, you can undo the changes and rerun the newly added case.

Copy link
Member

sdispater left a comment

Looks good to me 👍

@sdispater sdispater merged commit 9d749a4 into python-poetry:master Dec 26, 2019
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
@sdispater

This comment has been minimized.

Copy link
Member

sdispater commented Dec 26, 2019

Thanks!

@frostming frostming deleted the frostming:bugfix/1782 branch Dec 27, 2019
shenek added a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.