Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add homebrew installation #1833

Closed

Conversation

@chenrui333
Copy link

chenrui333 commented Jan 5, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Fixes #1765
Relates to Homebrew/homebrew-core#48545

@chenrui333

This comment has been minimized.

Copy link
Author

chenrui333 commented Jan 6, 2020

cc @finswimmer

The poetry has been released in homebrew side, I think this PR can be merged.

@sdispater

This comment has been minimized.

Copy link
Member

sdispater commented Jan 6, 2020

Thank you for your contribution!

However, I don't think I want to move forward with this. First, you added the homebrew instructions to the Installation section which is for the official installer and not alternative methods. Second, adding it to the documentation might give the impression that it is official, i.e. that the core contributors are somehow involved with, and people might think, rightly, that asking questions for support here is the right place.

We already have a lot of work to do and responding to questions or debugging the homebrew installation could add noise and extra work for us.

I would like to thank you again though for contributing to Poetry and to help making it more widely available by providing alternative ways to install it. We really appreciate it.

@sdispater sdispater closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.