Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't export local file dependency as editable (#897) #1840

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@finswimmer
Copy link
Member

finswimmer commented Jan 7, 2020

At the moment local file dependencies are export as editable. This is not valid.

Fixes: #897

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.
@finswimmer finswimmer requested a review from python-poetry/core Jan 7, 2020
poetry/utils/exporter.py Outdated Show resolved Hide resolved
@finswimmer finswimmer requested a review from sdispater Jan 8, 2020
@sdispater sdispater merged commit 4fe3c52 into python-poetry:master Jan 9, 2020
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.