Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading packages from Simplepypi #1851

Merged
merged 3 commits into from Jan 31, 2020
Merged

Conversation

@leftys
Copy link
Contributor

leftys commented Jan 9, 2020

Hi! Submiting a small PR to fix issue breaking fetching packages from simplepypi repositories.

The reason is that simplepypi returns http header 'Content-encoding: gzip' and requests automatically decompresses these files (see http://docs.python-requests.org/en/master/user/quickstart/#raw-response-content). So the resulted file is not "gzipped" but only "tarred" and an exception is raised. This is described in #517

@leftys leftys changed the title fix downloading packages from simplepypi Fix downloading packages from Simplepypi Jan 9, 2020
leftys added 2 commits Jan 9, 2020
@leftys leftys requested a review from sdispater Jan 17, 2020
Copy link
Member

sdispater left a comment

Looks good to me 👍

Thanks!

@sdispater sdispater merged commit d331535 into python-poetry:master Jan 31, 2020
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
MrGreenTea added a commit to MrGreenTea/poetry that referenced this pull request Feb 14, 2020
* fix downloading packages from simplepypi

* unused code removed

* remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.