Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "create PEP508 compliant dependency string for directory and file dependencies (#1796)" #1865

Merged
merged 1 commit into from Jan 10, 2020

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jan 10, 2020

This reverts commit 10e471a.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

#1796 is causing errors when directory and file dependencies are present in the pyproject.toml
file. This is caused by the PEP-508 compliant dependency strings being added to the generated setup.py file which is not currently supported.

@sdispater sdispater requested a review from finswimmer Jan 10, 2020
@sdispater sdispater merged commit f1b286c into master Jan 10, 2020
32 checks passed
@sdispater sdispater deleted the revert-pr-1796 branch Jan 10, 2020
@sdispater sdispater mentioned this pull request Jan 10, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants