Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "create PEP508 compliant dependency string for directory and file dependencies (#1796)" #1865

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@sdispater
Copy link
Member

sdispater commented Jan 10, 2020

This reverts commit 10e471a.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

#1796 is causing errors when directory and file dependencies are present in the pyproject.toml
file. This is caused by the PEP-508 compliant dependency strings being added to the generated setup.py file which is not currently supported.

…ile dependencies (#1796)"

This reverts commit 10e471a.
@sdispater sdispater requested a review from finswimmer Jan 10, 2020
@sdispater sdispater merged commit f1b286c into master Jan 10, 2020
32 checks passed
32 checks passed
Linting
Details
Linting
Details
Linux (2.7)
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.7)
Details
Linux (3.8)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.7)
Details
Windows (3.8)
Details
Windows (3.8)
Details
@sdispater sdispater deleted the revert-pr-1796 branch Jan 10, 2020
@sdispater sdispater mentioned this pull request Jan 10, 2020
0 of 2 tasks complete
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.