Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_requires_for_build_wheel must return additional build requirements and not dependencies (#1689) #1875

Merged
merged 1 commit into from Jan 20, 2020

Conversation

@finswimmer
Copy link
Member

finswimmer commented Jan 13, 2020

At the moment get_requires_for_build_wheel and get_requires_for_build_sdist returns the dependencies of the packages. This is wrong. According to PEP517 they should return additional requirements, not listed in the pyproject.toml, needed to build the package.

The implementation of this methods is optional. If not implemented the default value is treated as an empty list. For completeness I would keep these method for maybe future implementation, but for now they return just an empty list.

Fixes: #1689

Thanks to @wakemaster39 for providing the correct input for this solution 馃憤

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.
鈥al list of requirements for building a package, not listed in `pyproject.toml` and not dependencies for the package itself

fix (tests): adopted tests
@finswimmer finswimmer requested a review from python-poetry/core Jan 13, 2020
@finswimmer finswimmer added the Bug label Jan 13, 2020
@wakemaster39 wakemaster39 mentioned this pull request Jan 13, 2020
0 of 2 tasks complete
Copy link
Member

sdispater left a comment

LGTM 馃憤

Thanks for getting to the bottom of this

@sdispater sdispater merged commit a0c9357 into python-poetry:master Jan 20, 2020
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
MrGreenTea added a commit to MrGreenTea/poetry that referenced this pull request Feb 14, 2020
鈥al list of requirements for building a package, not listed in `pyproject.toml` and not dependencies for the package itself (python-poetry#1875)

fix (tests): adopted tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.