Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how repository credentials are retrieved from env vars #1909

Merged
merged 1 commit into from Jan 31, 2020

Conversation

@sdispater
Copy link
Member

sdispater commented Jan 17, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR fixes the issue where repository credentials were not retrieve from the environment variables as documented here: https://python-poetry.org/docs/repositories/#configuring-credentials

Fixes #1807

@sdispater sdispater requested a review from python-poetry/core Jan 17, 2020
Copy link
Contributor

k4nar left a comment

Tested locally 👍

@sdispater sdispater force-pushed the fix-repository-credentials-from-env-vars branch from 0ec04c4 to aeae9d0 Jan 21, 2020
# Conflicts:
#	poetry/utils/password_manager.py
@sdispater sdispater force-pushed the fix-repository-credentials-from-env-vars branch from aeae9d0 to 41b3615 Jan 31, 2020
@sdispater sdispater merged commit 4687ef8 into master Jan 31, 2020
32 checks passed
32 checks passed
Linting
Details
Linting
Details
Linux (2.7)
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.7)
Details
Linux (3.8)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.7)
Details
Windows (3.8)
Details
Windows (3.8)
Details
@sdispater sdispater deleted the fix-repository-credentials-from-env-vars branch Jan 31, 2020
MrGreenTea added a commit to MrGreenTea/poetry that referenced this pull request Feb 14, 2020
…etry#1909)

# Conflicts:
#	poetry/utils/password_manager.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.