Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VCS when git is not in PATH #2105

Merged
merged 1 commit into from Feb 29, 2020
Merged

Conversation

@adisbladis
Copy link
Contributor

adisbladis commented Feb 28, 2020

This is a regression in 1.0.4, errors out when Git is not in PATH.

Fixes: #2108
Fixes: #2107

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

- [ ] Added tests for changed code.
- [ ] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

cc @sdispater @finswimmer

@jr314159 jr314159 mentioned this pull request Feb 29, 2020
3 of 3 tasks complete
Copy link
Member

finswimmer left a comment

Good catch 👍

Thanks a lot!

@finswimmer finswimmer merged commit ae96feb into python-poetry:master Feb 29, 2020
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.