Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VCS when git is not in PATH #2105

Merged
merged 1 commit into from Feb 29, 2020
Merged

Conversation

adisbladis
Copy link
Contributor

@adisbladis adisbladis commented Feb 28, 2020

This is a regression in 1.0.4, errors out when Git is not in PATH.

Fixes: #2108
Fixes: #2107

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

- [ ] Added tests for changed code.
- [ ] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

cc @sdispater @finswimmer

Copy link
Member

@finswimmer finswimmer left a comment

Good catch 👍

Thanks a lot!

@finswimmer finswimmer merged commit ae96feb into python-poetry:master Feb 29, 2020
16 checks passed
@cjjohansen
Copy link

@cjjohansen cjjohansen commented Jun 17, 2022

poetry version 1.1.13
This is still an issue for me. I get this error when running poetry install from docker file

@neersighted
Copy link
Member

@neersighted neersighted commented Jun 17, 2022

poetry version 1.1.13 This is still an issue for me. I get this error when running poetry install from docker file

Please open a new issue if you're experiencing a regression with details and a reproduction. Additionally, Poetry 1.2 is in beta and should not have this issue as we no longer depend on a system Git client -- please test it in your environment if you are able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants