Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle connection errors when publishing #2285

Merged
merged 1 commit into from Apr 12, 2020

Conversation

abn
Copy link
Member

@abn abn commented Apr 9, 2020

This change ensures connection errors are handled explicitly for
cases where there are network issues.

In addition to the above, this includes type hint updates and minor
refactor.

Relates to: #920

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This change ensures connection errors are handled explicitly for
cases where there are network issues.

In addition to the above, this includes type hint updates and minor
refactor.
@abn abn force-pushed the publish-connection-error branch from ebd1fbf to a57b015 Compare Apr 9, 2020
Copy link
Member

@kasteph kasteph left a comment

This looks good to me. 💫

@abn abn merged commit 7d50a8e into python-poetry:develop Apr 12, 2020
@abn abn deleted the publish-connection-error branch Apr 12, 2020
@sdispater sdispater mentioned this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants