Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy repositories packages being continuously updated #2525

Merged

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jun 9, 2020

Following the fix in #2484, installed packages with the same version were continuously updated. This was caused by a check in the Solver class that compared the source types of both packages and if they were different it would trigger an update.

This is fixed by ensuring we do this check only if the installed packages already has a source type.

Pull Request Check List

Resolves: #2502

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added Bug Installation labels Jun 9, 2020
@sdispater sdispater added this to Review in Bugs Jun 9, 2020
@sdispater sdispater merged commit b6c5c1e into master Jun 9, 2020
32 checks passed
Bugs automation moved this from Review to Closed Jun 9, 2020
@sdispater sdispater deleted the fix-persistent-update-for-legacy-repositories-packages branch Jun 9, 2020
@sdispater sdispater mentioned this pull request Jun 9, 2020
@sdispater sdispater mentioned this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Installation
Projects
Bugs
  
Closed
Development

Successfully merging this pull request may close these issues.

1 participant