Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tasks are cancelled when executor is shut down #2656

Merged
merged 1 commit into from Jul 13, 2020

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jul 12, 2020

Follow up to #2595.

This change was actually removed inadvertently in #2595. This PR adds it back.

cc @davidszotten

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the area/installer Related to the dependency installer label Jul 12, 2020
@sdispater sdispater added this to the 1.1 milestone Jul 12, 2020
@sdispater sdispater added this to In progress in 1.1 via automation Jul 12, 2020
@sdispater sdispater merged commit 1598dff into develop Jul 13, 2020
1.1 automation moved this from In progress to Done Jul 13, 2020
@sdispater sdispater deleted the cancel-operation-tasks-on-executor-shutdown branch Jul 13, 2020
@sdispater sdispater mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer Related to the dependency installer
Projects
No open projects
1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants