Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise on using virtualenv package #2666

Merged
merged 1 commit into from Jul 14, 2020

Conversation

abn
Copy link
Member

@abn abn commented Jul 13, 2020

Until now poetry used the built-in venv module available in Python 3.
This has presented a few concerns. Chief of which has been
inconsistent environment setup. This includes, but is not limited to,
pip version used by the ensurepip module which is in turn used by the
built-in venv.EnvBuilder. Additionally, the virtualenv package
allows for faster environment creation. This can also allow us to, going
forward, drop ad-hoc code required to inspect and manage environments.

See also: #2650
Closes: #732

  • Added tests for changed code.]

@abn abn requested a review from sdispater July 13, 2020 21:44
Until now poetry used the built-in venv module available in Python 3.
This has presented a few concerns. Chief of which has been
inconsistent environment setup. This includes, but is not limited to,
pip version used by the `ensurepip` module which is in turn used by the
built-in `venv.EnvBuilder`. Additionally, the `virtualenv` package
allows for faster environment creation. This can also allow us to, going
forward, drop ad-hoc code required to inspect and manage environments.
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sdispater sdispater merged commit d5a99f0 into python-poetry:develop Jul 14, 2020
@sdispater sdispater mentioned this pull request Jul 24, 2020
@abn abn deleted the virtualenv branch September 23, 2020 14:20
@senpos senpos mentioned this pull request Oct 7, 2020
2 tasks
@abn abn linked an issue Nov 2, 2020 that may be closed by this pull request
3 tasks
@abn abn mentioned this pull request Mar 29, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants