Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 and 3.5 deprecation #2683

Merged
merged 2 commits into from Jul 23, 2020
Merged

Python 2.7 and 3.5 deprecation #2683

merged 2 commits into from Jul 23, 2020

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jul 17, 2020

This PR makes the necessary changes to notify users of the deprecation of Python 2.7 and 3.5 in Poetry:

  • The documentation has been updated
  • The CLI will now display a message when using Python 2.7 and 3.5.

Screenshot 2020-07-17 at 16 44 09

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added area/cli Related to the command line area/docs Documentation issues/improvements labels Jul 17, 2020
@sdispater sdispater added this to the 1.1 milestone Jul 17, 2020
@sdispater sdispater requested a review from a team Jul 17, 2020
@sdispater sdispater added this to In progress in 1.1 via automation Jul 17, 2020
@sdispater sdispater mentioned this pull request Jul 17, 2020
14 tasks
@sdispater sdispater force-pushed the python-2-7-and-3-5-deprecation branch from cf4103f to 4e6a2a0 Compare Jul 18, 2020
@abn
Copy link
Member

abn commented Jul 18, 2020

@sdispater we should probably clarify that we are talking about poetry's runtime and not the managed project's python version.

@sdispater sdispater force-pushed the python-2-7-and-3-5-deprecation branch from 4e6a2a0 to 6e72aec Compare Jul 18, 2020
@sdispater
Copy link
Member Author

sdispater commented Jul 18, 2020

@abn I added a note that should clarify that Poetry will still be able to manage any Python environment.

Screenshot 2020-07-19 at 00 45 47

abn
abn approved these changes Jul 23, 2020
1.1 automation moved this from In progress to Reviewer approved Jul 23, 2020
@abn abn merged commit ca1c397 into develop Jul 23, 2020
1.1 automation moved this from Reviewer approved to Done Jul 23, 2020
@abn abn deleted the python-2-7-and-3-5-deprecation branch Jul 23, 2020
@sdispater sdispater mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to the command line area/docs Documentation issues/improvements
Projects
No open projects
1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants