Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect resolution errors for dependencies with looser python constraints #2712

Merged

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jul 24, 2020

This fixes issues in the dependency resolution process whenever a package has a specific python requirement and the corresponding dependency has a python restriction looser than the root package Python requirements.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added kind/bug Something isn't working as expected area/solver Related to the dependency resolver labels Jul 24, 2020
@sdispater sdispater requested a review from a team Jul 24, 2020
abn
abn approved these changes Jul 24, 2020
@sdispater sdispater merged commit 2ba36c8 into master Jul 24, 2020
@sdispater sdispater deleted the fix-resolution-for-packages-with-irrelevant-difference branch Jul 24, 2020
@sdispater sdispater mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants