Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle poetry init non-interactive dependencies #2899

Merged
merged 5 commits into from Jun 23, 2021

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Sep 10, 2020

  1. in non-interactive mode, suppress "This command will guide you through..."
  2. in interactive mode, respect command line --dependency if the user chooses NO for "Would you like to define your main dependencies interactively?"

1. in non-interactive mode, suppress "This command will guide you through..."
2. in interactive mode, respect command line --dependency if the user chooses NO for "Would you like to define your main dependencies interactively?"
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution 👍

Just a minor change request.

And can you please also create a test for the non-interactive poetry init please?

fin swimmer

Comment on lines +168 to +169
if self.io.is_interactive():
self.line("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we really need this self.line(""). I guess at least it can be placed directly after the last output above and we can avoid this second if-statement.

Same thing applies to line 183-184.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It serves to separate the interactive output of _determine_requirements, so that would change the output. Still want the change?

@rotu
Copy link
Contributor Author

rotu commented Sep 24, 2020

@finswimmer Any more actions needed from me? It looks like the check failed for mysterious reasons unrelated to my development.

@finswimmer
Copy link
Member

@rotu: Could you please rebase onto master and see what happens to the checks?

@rotu
Copy link
Contributor Author

rotu commented Sep 24, 2020

@finswimmer, backmerged master

@finswimmer
Copy link
Member

@rotu: Thanks a lot. The tests passes now, but now we have a conflict. :( Can you please resolve it?

Thanks a lot for your contribution!

@finswimmer finswimmer merged commit 7fac676 into python-poetry:master Jun 23, 2021
abn added a commit to abn/poetry that referenced this pull request Jun 27, 2021
abn added a commit that referenced this pull request Jun 27, 2021
@sdispater sdispater mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants