Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'rc' to VERSION_REGEX #2978

Merged
merged 1 commit into from Sep 25, 2020
Merged

Conversation

adawalli
Copy link
Contributor

@adawalli adawalli commented Sep 25, 2020

The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: #2977

The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: python-poetry#2977
@adawalli
Copy link
Contributor Author

adawalli commented Sep 25, 2020

@abn any ideas why this failed - I tested on debian 2.7 and cannot reproduce - is there something wrong with the test?

@abn
Copy link
Member

abn commented Sep 25, 2020

Intermittent failure. Will re-run.

abn
abn approved these changes Sep 25, 2020
@abn abn merged commit fa0881d into python-poetry:master Sep 25, 2020
@sdispater sdispater mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer Installs PREVIEW release even when POETRY_PREVIEW=0
2 participants