Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix incorrect return value #2981

Merged
merged 1 commit into from Sep 27, 2020

Conversation

abn
Copy link
Member

@abn abn commented Sep 26, 2020

Seems we were relying on the implicit casting of boolean/int for the execute method.

@abn abn requested a review from a team Sep 26, 2020
@abn abn added this to In progress in 1.1 via automation Sep 26, 2020
@abn abn added this to the 1.1 milestone Sep 26, 2020
1.1 automation moved this from In progress to Reviewer approved Sep 27, 2020
@finswimmer finswimmer merged commit 346da80 into python-poetry:master Sep 27, 2020
1.1 automation moved this from Reviewer approved to Done Sep 27, 2020
@abn abn deleted the fix/executor-return-value branch Sep 28, 2020
@sdispater sdispater mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants