Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock: allow for no-update refresh of lock files #3034

merged 1 commit into from Oct 2, 2020


Copy link

@abn abn commented Oct 1, 2020

With the changes to the lock file it is important that users are able to refresh their lock files without updating compatible versions.

Relates-to: #3028

@abn abn added the kind/feature Feature requests/implementations label Oct 1, 2020
@abn abn added this to In progress in 1.1 via automation Oct 1, 2020
@abn abn added this to In progress in 1.2 via automation Oct 1, 2020
@abn abn requested a review from a team October 1, 2020 23:19
@abn abn modified the milestones: 1.1, 1.2 Oct 1, 2020
@abn abn force-pushed the lock/no-update branch 2 times, most recently from 4e95465 to a34ace2 Compare October 1, 2020 23:26
@abn abn changed the base branch from master to 1.1 October 1, 2020 23:42
@abn abn removed this from In progress in 1.2 Oct 1, 2020
Copy link

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Nonetheless, we should add some tests to ensure everything is in order.

@abn abn removed this from the 1.2 milestone Oct 1, 2020
1.1 automation moved this from In progress to Review in progress Oct 1, 2020
Copy link
Member Author

abn commented Oct 2, 2020

@sdispater added a test case for this as well

@abn abn requested review from a team and sdispater October 2, 2020 01:13
1.1 automation moved this from Review in progress to Reviewer approved Oct 2, 2020
@abn abn merged commit 7c15b98 into python-poetry:1.1 Oct 2, 2020
1.1 automation moved this from Reviewer approved to Done Oct 2, 2020
@abn abn deleted the lock/no-update branch October 2, 2020 09:14
@abn abn mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
kind/feature Feature requests/implementations
No open projects

Successfully merging this pull request may close these issues.

None yet

2 participants