Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (utils.patterns): recognize one digit version in filename #3338

merged 1 commit into from Mar 30, 2021


Copy link

The current regex for wheel filename doesn't recognize one digit versions in the filename. This PR fixes this.

Furthermore the current regex makes the version part in the wheel name optional. According to PEP 491 this part is mandatory. This is fixed by this PR as well.

Feel free to provide more filenames for the tests :)

Pull Request Check List

Resolves: #3320

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer requested a review from a team November 7, 2020 14:49
jedie previously approved these changes Nov 11, 2020
abn previously requested changes Nov 19, 2020
Copy link

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor recommendation to make things a bit more explicit.

tests/utils/ Show resolved Hide resolved
fix (utils.patterns): version part in filename must be present according PEP491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants