fix (utils.patterns): recognize one digit version in filename#3338
Merged
Conversation
3 tasks
jedie
previously approved these changes
Nov 11, 2020
abn
previously requested changes
Nov 19, 2020
abn
left a comment
abn
left a comment
Member
There was a problem hiding this comment.
Minor recommendation to make things a bit more explicit.
dhiltonp
added a commit
to dhiltonp/poetry
that referenced
this pull request
Nov 24, 2020
finswimmer
force-pushed
the
issue/3320-wheel-file-re
branch
2 times, most recently
from
8fc0105 to
d5f7944
Compare
fix (utils.patterns): version part in filename must be present according PEP491
finswimmer
force-pushed
the
issue/3320-wheel-file-re
branch
from
d5f7944 to
959d2cd
Compare
kasteph
approved these changes
Mar 30, 2021
Merged
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current regex for wheel filename doesn't recognize one digit versions in the filename. This PR fixes this.
Furthermore the current regex makes the version part in the wheel name optional. According to PEP 491 this part is mandatory. This is fixed by this PR as well.
Feel free to provide more filenames for the tests :)
Pull Request Check List
Resolves: #3320