Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI registry correctly to pool depending on other sources/Fix source.secondary = true being ignored #3406

Merged

Conversation

tomzx
Copy link
Contributor

@tomzx tomzx commented Nov 24, 2020

In the event where we defined sources that were set as
secondary = True, we would end up with PyPI being after this source
when it should have acted as default in that case.

The main issue stems from the fact that it's not because you have
sources configured that PyPI should not be a default. Instead, PyPI
should be default if there are no sources with secondary = False and
not default if there are sources with secondary = True.

Resolves #2339, resolves #3306, resolves #3238

@tomzx tomzx force-pushed the fixes/source-default-secondary-logic branch from 45c7b20 to 99b9d80 Compare November 24, 2020 04:55
@tomzx tomzx changed the title Add PyPI registry correctly to pool depending on other sources Add PyPI registry correctly to pool depending on other sources/Fix source.secondary = true being ignored Nov 24, 2020
aviramha
aviramha previously approved these changes Nov 24, 2020
Copy link
Contributor

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@maksbotan
Copy link
Contributor

I can confirm it works, thanks! Looking forward for a release.

@aviramha
Copy link
Contributor

@abn any chance to merge this? This is quite an issue for us.

@dbuades
Copy link

dbuades commented Jan 12, 2021

Same thing here, we found this error today in different computers. It would be great if this could be merged!

@michaeljoy
Copy link

Still an issue, when will this make it into master?

@skylerwshaw
Copy link

@tomzx @aviramha When can we expect a merge and release? Thanks!

@tomzx
Copy link
Contributor Author

tomzx commented Jan 23, 2021

@skylerwshaw I cannot merge this since I am not a maintainer. Merging is currently blocked due to

At least 1 approving review is required by reviewers with write access.

Drachenfels
Drachenfels previously approved these changes Feb 3, 2021
@pPanda-beta
Copy link

"A stitch in time saves nine" - should have merged already. People are suffering out there because of the secondary repositories.

@ylathouris
Copy link

ylathouris commented Feb 18, 2021

@maksbotan - are we able to get a second approval on this?

ylathouris
ylathouris previously approved these changes Feb 19, 2021
In the event where we defined sources that were set as
secondary = True, we would end up with PyPI being after this source
when it should have acted as default in that case.

The main issue stems from the fact that it's not because you have
sources configured that PyPI should not be a default. Instead, PyPI
should be default if there are no sources with secondary = False and
not default if there are sources with secondary = True.
@tomzx tomzx dismissed stale reviews from ylathouris, Drachenfels, and aviramha via b2defd1 February 19, 2021 01:37
@tomzx tomzx force-pushed the fixes/source-default-secondary-logic branch from 99b9d80 to b2defd1 Compare February 19, 2021 01:37
@tomzx
Copy link
Contributor Author

tomzx commented Mar 3, 2021

Hello all! I have rebased the PR which appears to have rendered the 3 prior approval stale.

@Drachenfels @ylathouris @aviramha Would you mind giving it another quick look (nothing has changed).

@sdispater @abn Would you be able to provide any feedback necessary to get this moving forward?

Thanks!

@abn abn requested a review from a team March 3, 2021 19:18
aviramha
aviramha previously approved these changes Mar 3, 2021
@chalupaul
Copy link

bueller.... bueller.... bueller.......

@maksbotan
Copy link
Contributor

@sdispater @abn @cereblanco hi! glad to see the project come to life again. Can you please look at this PR, as it fixes a nasty regression that blocks some users from upgrading to 1.1.4?

@FraBle
Copy link

FraBle commented Apr 4, 2021

Conflicting files
poetry/factory.py

😭

@tomzx
Copy link
Contributor Author

tomzx commented Apr 4, 2021

Conflicting files
poetry/factory.py

😭

That's resolved.

@maksbotan
Copy link
Contributor

@abn hi! this serious regression still did not get any attention from the developers...

@abn abn self-assigned this Apr 20, 2021
@aviramha aviramha mentioned this pull request Apr 25, 2021
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sdispater sdispater merged commit a3c5cf7 into python-poetry:master Apr 26, 2021
@caniko
Copy link

caniko commented Jul 1, 2021

This didn't solve the problem for me.

@jstriebel
Copy link
Contributor

Just noticed that this PR was merged to the master branch which is used for the 1.2 development, while the current 1.1.x releases are from the 1.1 branch. Since this fix would be quite useful, I added PR #4241 for the 1.1 branch, hoping to have this in a patch-release soon.

abn pushed a commit that referenced this pull request Jul 3, 2021
Add PyPI registry correctly to pool depending on other sources (#3406)

In the event where we defined sources that were set as
secondary = True, we would end up with PyPI being after this source
when it should have acted as default in that case.

The main issue stems from the fact that it's not because you have
sources configured that PyPI should not be a default. Instead, PyPI
should be default if there are no sources with secondary = False and
not default if there are sources with secondary = True.
@tomzx tomzx deleted the fixes/source-default-secondary-logic branch July 6, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet