Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new version of Cleo #3618

merged 1 commit into from Feb 2, 2021

Migrate to the new version of Cleo #3618

merged 1 commit into from Feb 2, 2021


Copy link

This PR changes the code base to migrate to the new, work in progress, version of Cleo which will help improve things in order to better implement some features planned for the 1.2 release.

The major changes are the following:

  • A new command loading system that make it possible to only load and execute the requested command without having to import any other command. This will help with performance issues when executing Poetry (note that a lot of changes must be done internally to improve performances further).
  • The sub command system has changed and now works by using namespaced commands to achieve the same thing.

@sdispater sdispater force-pushed the new-cleo branch 4 times, most recently from 6fc3f80 to 3d45a4e Compare January 29, 2021 22:10
@sdispater sdispater marked this pull request as ready for review January 29, 2021 23:03
@sdispater sdispater requested a review from a team January 29, 2021 23:04
@jules-ch jules-ch mentioned this pull request Jan 31, 2021
3 tasks
Copy link

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

I recognize that you've started to use type hints instead of type comments. I've avoided this in my PRs regarding adding missing type hints, to make cherry-picking to the 1.1 easier. But I guess once this PR is merged, we should switch the type comments to type hints (with com2ann this seems to be quiet easy) for the sake of consistency.

I let it to you to merge this PR.

Copy link
Member Author

@finswimmer The master branch is already Python 3.6+ only so there is no reason not to use type hints, that's why I started introducing them.

And, yes, I plan on converting everything to type hints.

@sdispater sdispater merged commit 855bc88 into master Feb 2, 2021
@sdispater sdispater deleted the new-cleo branch February 2, 2021 11:30
Copy link

This morning I noticed that "poetry env info -p" and "poetry env info --path" are failing with a stack trace; a bisect narrowed it down to this PR. I haven't had a chance to dig into it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants