From 2918d759bf462082280ede971a5222fe01634ed8 Mon Sep 17 00:00:00 2001 From: Rolf Erik Lekang Date: Tue, 18 Aug 2015 22:24:49 +0200 Subject: [PATCH] fix(history): Fix level id's in angular parser --- semantic_release/history/parser_angular.py | 10 +++++----- tests/test_parsers.py | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/semantic_release/history/parser_angular.py b/semantic_release/history/parser_angular.py index 719bc3eba..3658e8207 100644 --- a/semantic_release/history/parser_angular.py +++ b/semantic_release/history/parser_angular.py @@ -36,18 +36,18 @@ def parse_commit_message(message): ) parsed = re_parser.match(message) - level_bump = 4 + level_bump = 0 if parsed.group('body') and 'BREAKING CHANGE' in parsed.group('body'): - level_bump = 1 + level_bump = 3 if parsed.group('footer') and 'BREAKING CHANGE' in parsed.group('footer'): - level_bump = 1 + level_bump = 3 if parsed.group('type') == 'feat': - level_bump = min([level_bump, 2]) + level_bump = max([level_bump, 2]) if parsed.group('type') == 'fix': - level_bump = min([level_bump, 2]) + level_bump = max([level_bump, 1]) return ( level_bump, diff --git a/tests/test_parsers.py b/tests/test_parsers.py index 8f838ec5b..db295b8a5 100644 --- a/tests/test_parsers.py +++ b/tests/test_parsers.py @@ -16,16 +16,16 @@ def test_parser_raises_unknown_message_style(self): def test_parser_return_correct_bump_level(self): self.assertEqual( angular_parser('feat(parsers): Add new parser pattern\n\nBREAKING CHANGE:')[0], - 1 + 3 ) self.assertEqual( angular_parser('feat(parsers): Add new parser pattern\n\n' 'New pattern is awesome\n\nBREAKING CHANGE:')[0], - 1 + 3 ) self.assertEqual(angular_parser('feat(parser): Add emoji parser')[0], 2) - self.assertEqual(angular_parser('fix(parser): Fix regex in angular parser')[0], 2) - self.assertEqual(angular_parser('test(parser): Add a test for angular parser')[0], 4) + self.assertEqual(angular_parser('fix(parser): Fix regex in angular parser')[0], 1) + self.assertEqual(angular_parser('test(parser): Add a test for angular parser')[0], 0) def test_parser_return_type_from_commit_message(self): self.assertEqual(angular_parser('feat(parser): ...')[1], 'feature') @@ -58,7 +58,7 @@ def test_parser_return_subject_from_commit_message(self): def test_parser_return_text_from_commit_message(self): self.assertEqual( - angular_parser('fix(parser): Fix regex in angular parser\n\n{}'.format(self.text))[3][1], + angular_parser('fix(parser): Fix regex in an parser\n\n{}'.format(self.text))[3][1], self.text )