From 6d1695320e09320f43efca403992d7d1791ff2a7 Mon Sep 17 00:00:00 2001 From: Rolf Erik Lekang Date: Sun, 20 Dec 2015 23:02:27 +0100 Subject: [PATCH] refactor: Fix quantified code warnings --- semantic_release/cli.py | 2 +- semantic_release/history/__init__.py | 4 ++-- semantic_release/history/logs.py | 2 +- semantic_release/settings.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/semantic_release/cli.py b/semantic_release/cli.py index 86df2fff2..b1fce7de0 100644 --- a/semantic_release/cli.py +++ b/semantic_release/cli.py @@ -75,7 +75,7 @@ def changelog(**kwargs): current_version = get_current_version() log = generate_changelog(get_previous_version(current_version), current_version) for section in CHANGELOG_SECTIONS: - if len(log[section]) == 0: + if not log[section]: continue click.echo(section.capitalize()) diff --git a/semantic_release/history/__init__.py b/semantic_release/history/__init__.py index a7442aba8..104ff5ecd 100644 --- a/semantic_release/history/__init__.py +++ b/semantic_release/history/__init__.py @@ -70,8 +70,8 @@ def set_new_version(new_version): content = fr.read() content = re.sub( - r'{} ?= ?["\']\d+\.\d+(?:\.\d+)?["\']'.format(variable), - '{} = \'{}\''.format(variable, new_version), + r'{0} ?= ?["\']\d+\.\d+(?:\.\d+)?["\']'.format(variable), + '{0} = \'{1}\''.format(variable, new_version), content ) diff --git a/semantic_release/history/logs.py b/semantic_release/history/logs.py index 721223bce..89f42b990 100644 --- a/semantic_release/history/logs.py +++ b/semantic_release/history/logs.py @@ -109,7 +109,7 @@ def markdown_changelog(version, changelog, header=False): output += '## v{0}\n'.format(version) for section in CHANGELOG_SECTIONS: - if len(changelog[section]) == 0: + if not changelog[section]: continue output += '\n### {0}\n'.format(section.capitalize()) diff --git a/semantic_release/settings.py b/semantic_release/settings.py index 3fe9dde10..cb8ae5933 100644 --- a/semantic_release/settings.py +++ b/semantic_release/settings.py @@ -24,7 +24,7 @@ def _config(): def current_commit_parser(): try: parts = config.get('semantic_release', 'commit_parser').split('.') - module = '.'.join(parts[:len(parts) - 1]) + module = '.'.join(parts[:-1]) return getattr(importlib.import_module(module), parts[-1]) except (ImportError, AttributeError) as error: raise ImproperConfigurationError('Unable to import parser "{}"'.format(error))