Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Properly join configuration URLs #588

Merged
merged 1 commit into from Dec 15, 2021

Conversation

eburkland
Copy link
Contributor

A Change was made in 3.4.0.0 commit (0a49eb5) which creates an improper "well-known" URL. Change it back please

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

A Change was made in 3.4.0.0 commit (0a49eb5) which creates an improper "well-known" URL.  Change it back please
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #588 (6330b3f) into master (ca68410) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         314      314           
  Lines        9471     9471           
  Branches      464      464           
=======================================
  Hits         7209     7209           
  Misses       2110     2110           
  Partials      152      152           
Flag Coverage Δ
unittests 76.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/okta.py 92.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca68410...6330b3f. Read the comment docs.

@nijel nijel merged commit 5c8f653 into python-social-auth:master Dec 15, 2021
@nijel
Copy link
Member

nijel commented Dec 15, 2021

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants