Add from_end kwarg to Stream.from_textfile()
#201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new keyword argument `from_end` to `Stream.from_textfile()` that allows streaming from the end of the file. This allows for streams that only emit lines that are appended to the file after `start()` is called. Addresses python-streamz#199. Uses `file.seek(0, 2)` to seek to the end of the file before polling for new lines.
martindurant
pushed a commit
to martindurant/streamz
that referenced
this pull request
Mar 20, 2019
Some effect as python-streamz#201, but should now pass tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new keyword argument
from_endtoStream.from_textfile()that allows streaming from the end of the file. This allows for streams that only emit lines that are appended to the file afterstart()is called. Addresses #199.Uses
file.seek(0, 2)to seek to the end of the file before polling for new lines.