Skip to content
Permalink
Browse files

Fix in telegram.Message

The `_parse_(html|markdown)` methods now properly return `None` on an empty `Message.text` or an empty `Message.caption`
  • Loading branch information...
Eldinnie committed Mar 12, 2018
1 parent 2b221da commit 345f637be0c74db4a62d0121e9e80329f2200164
Showing with 26 additions and 0 deletions.
  1. +6 −0 telegram/message.py
  2. +20 −0 tests/test_message.py
@@ -868,6 +868,9 @@ def parse_caption_entities(self, types=None):

@staticmethod
def _parse_html(message_text, entities, urled=False):
if not message_text:
return None

if not sys.maxunicode == 0xffff:
message_text = message_text.encode('utf-16-le')

@@ -962,6 +965,9 @@ def caption_html_urled(self):

@staticmethod
def _parse_markdown(message_text, entities, urled=False):
if not message_text:
return None

if not sys.maxunicode == 0xffff:
message_text = message_text.encode('utf-16-le')

@@ -173,6 +173,11 @@ def test_text_html_simple(self):
text_html = self.test_message.text_html
assert text_html == test_html_string

def test_text_html_empty(self, message):
message.text = None
message.caption = "test"
assert not message.text_html

This comment has been minimized.

Copy link
@jh0ker

jh0ker Mar 12, 2018

Member

Maybe change this to assert message.text_html is None ? Same for below


def test_text_html_urled(self):
test_html_string = ('Test for &lt;<b>bold</b>, <i>ita_lic</i>, <code>code</code>, '
'<a href="http://github.com/">links</a> and <pre>pre</pre>. '
@@ -186,6 +191,11 @@ def test_text_markdown_simple(self):
text_markdown = self.test_message.text_markdown
assert text_markdown == test_md_string

def test_text_markdown_empty(self, message):
message.text = None
message.caption = "test"
assert not message.text_markdown

def test_text_markdown_urled(self):
test_md_string = ('Test for <*bold*, _ita\_lic_, `code`, [links](http://github.com/) and '
'```pre```. [http://google.com](http://google.com)')
@@ -215,6 +225,11 @@ def test_caption_html_simple(self):
caption_html = self.test_message.caption_html
assert caption_html == test_html_string

def test_caption_html_empty(self, message):
message.text = "test"
message.caption = None
assert not message.caption_html

def test_caption_html_urled(self):
test_html_string = ('Test for &lt;<b>bold</b>, <i>ita_lic</i>, <code>code</code>, '
'<a href="http://github.com/">links</a> and <pre>pre</pre>. '
@@ -228,6 +243,11 @@ def test_caption_markdown_simple(self):
caption_markdown = self.test_message.caption_markdown
assert caption_markdown == test_md_string

def test_caption_markdown_empty(self, message):
message.text = "test"
message.caption = None
assert not message.caption_markdown

def test_caption_markdown_urled(self):
test_md_string = ('Test for <*bold*, _ita\_lic_, `code`, [links](http://github.com/) and '
'```pre```. [http://google.com](http://google.com)')

0 comments on commit 345f637

Please sign in to comment.
You can’t perform that action at this time.