Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] tuples aren't accepted in static typing #2125

Closed
Poolitzer opened this issue Oct 9, 2020 · 2 comments · Fixed by #2167
Closed

[BUG] tuples aren't accepted in static typing #2125

Poolitzer opened this issue Oct 9, 2020 · 2 comments · Fixed by #2167
Labels
good first issue hacktoberfest type hinting Not bug. Not Docs. But both.

Comments

@Poolitzer
Copy link
Member

Currently, we only accept list where tuples work as well. That should be added to the type hints where applicable.
@Bibo-Joshi Bibo-Joshi added type hinting Not bug. Not Docs. But both. and removed bug 🐛 labels Oct 10, 2020
@gutsytechster
Copy link

@Poolitzer can you refer to some piece of code, as where exactly are you referring to?

@Poolitzer Telegram GithubBot Revised
Copy link
Member Author

@gutsytechster ext.filters.Filters.user would be an example

@Pranjalya Pranjalya mentioned this issue Oct 16, 2020
Closed
@eIGato eIGato mentioned this issue Oct 31, 2020
Merged
eIGato added a commit to eIGato/python-telegram-bot that referenced this issue Nov 2, 2020
@eIGato
Fix list/tuple related isinstance() checks
1532685 
Issue: python-telegram-bot#2125
eIGato added a commit to eIGato/python-telegram-bot that referenced this issue Nov 2, 2020
@eIGato
Add SLT generic
b6e55d5 
Single instance or list/tuple of instances.

Issue: python-telegram-bot#2125
eIGato added a commit to eIGato/python-telegram-bot that referenced this issue Nov 2, 2020
@eIGato
Add SLT generic
4123b5e 
Single instance or list/tuple of instances.

Issue: python-telegram-bot#2125
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue hacktoberfest type hinting Not bug. Not Docs. But both.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Tuple option to arguments type hints eIGato/python-telegram-bot
3 participants
@Bibo-Joshi @Poolitzer @gutsytechster