New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caption_(html|markdown)(_urled)? #1013

Merged
merged 6 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@Eldinnie
Member

Eldinnie commented Feb 19, 2018

Closes #1010

@python-telegram-bot python-telegram-bot deleted a comment from codecov bot Feb 19, 2018

@tsnoam
  1. I like it how you used from html import escape and gaining from future.
    However, in helpers.py we still use the approach. Maybe fix there too?
  2. I had some small nitpicks on the code (look on the comments).
  3. Other than that, looks good :)
Show outdated Hide outdated telegram/message.py
Show outdated Hide outdated telegram/message.py
Show outdated Hide outdated telegram/message.py
Show outdated Hide outdated telegram/message.py
@tsnoam

tsnoam approved these changes Feb 22, 2018

Eldinnie added some commits Feb 22, 2018

@tsnoam tsnoam merged commit b275031 into master Feb 22, 2018

4 checks passed

codecov/patch 96% of diff hit (target 92.08%)
Details
codecov/project 92.11% (+0.03%) compared to a9a503b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsnoam tsnoam deleted the Add_1010 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment