Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sphinx to py3 #1096

Merged
merged 3 commits into from May 3, 2018

Conversation

Projects
None yet
3 participants
@Eldinnie
Copy link
Member

Eldinnie commented Apr 30, 2018

No description provided.

Eldinnie added some commits Apr 30, 2018

Use python 3 on read the docs
This has multiple improvements on the inspection of classes. Mainly that method signatures propely display the arguments for the method.
Add note to telegram.Bot about camelCase
Switching to py3 means that the camelCase method descriptors will no longer be displayed in the docs. Adding a note to Bot to clarify they exist.
@@ -291,17 +291,9 @@

# -- script stuff --------------------------------------------------------

import inspect


def autodoc_skip_member(app, what, name, obj, skip, options):

This comment has been minimized.

@jsmnbom

jsmnbom Apr 30, 2018

Member

We can probably remove the whole "script stuff" and below now :)

This comment has been minimized.

@Eldinnie

Eldinnie May 3, 2018

Author Member

It's a part of the template so leaving it in.

@tsnoam

This comment has been minimized.

Copy link
Member

tsnoam commented May 3, 2018

@Eldinnie @bomjacob
I think this is good merge, no?

@Eldinnie

This comment has been minimized.

Copy link
Member Author

Eldinnie commented May 3, 2018

Yes

@Eldinnie Eldinnie merged commit 3bef2fa into master May 3, 2018

5 checks passed

Hound No violations found. Woof!
codecov/patch 100% of diff hit (target 92.45%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +7.54% compared to 78fee3c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eldinnie Eldinnie deleted the sphinxtopy3 branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.