Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch urllib3.RequestField to make it *not* support RFC2231 #1214

Merged
merged 4 commits into from Sep 10, 2018

Conversation

@jsmnbom
Copy link
Member

jsmnbom commented Sep 10, 2018

Fixes #1202

@jsmnbom jsmnbom changed the title Patch urllib3RequestField to make it *not* support RFC2231 Patch urllib3.RequestField to make it *not* support RFC2231 Sep 10, 2018
@tsnoam
tsnoam approved these changes Sep 10, 2018
"""
Regression test for https://github.com/python-telegram-bot/python-telegram-bot/issues/1202
"""
with open('tests/data/测试.png', 'rb') as f:

This comment has been minimized.

Copy link
@Eldinnie

Eldinnie Sep 10, 2018

Member

this needs a u'filename' prefix for py2.7 to work

This comment has been minimized.

Copy link
@jsmnbom

jsmnbom Sep 10, 2018

Author Member

Ah great.. that was what I was missing. Thanks :D

@Eldinnie

This comment has been minimized.

Copy link
Member

Eldinnie commented Sep 10, 2018

left a review. Needs fixing

jsmnbom added 2 commits Sep 10, 2018
Not needed anymore, and also makes it not work... so that was not great
@jsmnbom jsmnbom merged commit e247fa7 into master Sep 10, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
@jsmnbom jsmnbom deleted the fix-1202 branch Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.