Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAITING state and behavior #1344

Merged
merged 2 commits into from Feb 14, 2019
Merged

Add WAITING state and behavior #1344

merged 2 commits into from Feb 14, 2019

Conversation

@Eldinnie
Copy link
Member

Eldinnie commented Feb 13, 2019

  • Remove run_async_timeout and timed_out_behavior arguments
  • replace with WAITING constant and behavior from states
  • never wait for promise to resolve (will hang up entire update queue
  • see #1250 for discussion
Eldinnie added 2 commits Feb 13, 2019
* Remove `run_async_timeout` and `timed_out_behavior` arguments
* replace with `WAITING` constant and behavior from states
* never wait for promise to resolve (will hang up entire update queue
* see #1250 for discussion
Pytest 4.2.1 has a weird bug on top level collect in 4.2.1 Fixing version to 4.2.0
@jsmnbom jsmnbom added this to the V12 milestone Feb 14, 2019
@Eldinnie Eldinnie merged commit cd7c642 into V12 Feb 14, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 28.57% of diff hit (target 92.53%)
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
codecov/project 92.81% (+0.28%) compared to 7e2dbdd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Eldinnie Eldinnie deleted the Fix_1250 branch Feb 14, 2019
@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 13, 2019
@falkolab

This comment has been minimized.

Copy link

falkolab commented Sep 20, 2019

Hi @Eldinnie please pay attention. Docs still has mention about run_async_timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.