Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified args and attrs in classes #3404

merged 74 commits into from Dec 27, 2022


Copy link

@lemontree210 lemontree210 commented Dec 2, 2022

closes #3109
changes for Dice and LoginUrl reflect those in a closed PR #3316

it was not done completely in #3314
(`user` attr needed addition)
not sure this is correct in the attrs, but
I'm not changing it:
data (:obj:`str` | :obj:`object`)
(it's only `str` in args)
* not sure I had to add the note for `invite_link` to args,
but it is there in Telegram API

* Telegram API contains no explicit limit
for `name` arg/attr
lemontree210 and others added 5 commits December 2, 2022 18:17
maybe "Can't be a live location" and
limit constants are not needed in attrs,
but it matches Telegram API
`file_size` in attrs had wrong type too
I didn't include Tip and ..seealso from `callback_data`
argument as I assume it is not put into attrs on purpose
it's not really needed, but at least monospace
font was in place, I think, so why not put a reference
from reading the docstr it isn't clear that it's
a method of Bot
@lemontree210 lemontree210 marked this pull request as ready for review December 9, 2022 16:37
Base automatically changed from doc-fixes to master December 15, 2022 14:20
@Bibo-Joshi Bibo-Joshi changed the base branch from master to doc-fixes December 16, 2022 18:29
@Bibo-Joshi Bibo-Joshi self-requested a review December 21, 2022 15:50
Copy link

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through everything (maybe not every single word :D) and tbh I didn't find anything to complain about 🙆‍♂️ You've been very thorough - also with keeping #3109 (comment) up to date 🤯

It makes sense in attrs but not in args
@lemontree210 lemontree210 merged commit ad42308 into doc-fixes Dec 27, 2022
@lemontree210 lemontree210 deleted the unified-args-and-attrs-3109 branch December 27, 2022 09:54
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 1, 2023
4 tasks
Bibo-Joshi added a commit that referenced this pull request Jan 1, 2023
Co-authored-by: Dmitry Kolomatskiy <>
Co-authored-by: Viicos <>
Co-authored-by: Harshil <>
Co-authored-by: Eisberge <>
Co-authored-by: Joshua Tang <>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

[Documentation] Add valuable information to attribute docstrings of telegram classes
5 participants