New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove de_json() #789
remove de_json() #789
Conversation
6ff70eb
to
05ca4fe
Compare
tests passed. review wanted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I think you got all the classes. Left two very minor comments though.
input_text_message_content_json = InputMessageContent.de_json(json_dict, bot) | ||
|
||
assert input_text_message_content_json is None | ||
def test_exspected_values(self, input_text_message_content): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error
|
||
|
||
@pytest.fixture(scope='class') | ||
def input_location_message_content(): | ||
return InputLocationMessageContent(TestInputLocationMessageContent.longitude, | ||
TestInputLocationMessageContent.latitude) | ||
return InputLocationMessageContent(longitude=TestInputLocationMessageContent.longitude, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add these as kwargs?
Throughout the rest of the test we pass as an arg if it's a arg and kwarg if kwarg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because they were in the wrong order and adding kwargs was lazier then reversing the order. Will fix though
@bomjacob I addressed your review changes. |
Remove unneeded and unused de_json and de_list methods from our library. The only usages for these methods in our lib were within each other's de_json methods and our tests.
Expect Travis to fail, let it run again when #788 is merged.
Fixes #778