New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stuff to keep up with new 'checkpoint' nomenclature #157

Closed
njsmith opened this Issue May 14, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@njsmith
Member

njsmith commented May 14, 2017

assert_yieldsassert_checkpoints
assert_no_yieldsassert_no_checkpoints just deprecate without replacement
yield_brieflycheckpoint
yield_briefly_no_cancelcheckpoint_never_cancelled, schedule_point, checkpoint_shielded, ...? checkpoint_ignore_cancelled? checkpoint_with_cancel_shield? never_cancelled_checkpoint? cancel_shielded_checkpoint
yield_if_cancelledcheckpoint_if_cancelled? if_cancelled_checkpoint?

yield_indefinitely can stay the same, or maybe block_indefinitely, block_task_indefinitely? Naw, let's make it yield_indefinitelywait_task_rescheduled, for parallelism with the other wait functions.

@njsmith

This comment has been minimized.

Member

njsmith commented May 14, 2017

Will probably do this right after landing the giant ssl branch of doom.

@njsmith njsmith referenced this issue Aug 21, 2017

Closed

Release 0.2.0 #299

15 of 17 tasks complete
@njsmith

This comment has been minimized.

Member

njsmith commented Aug 31, 2017

Actually, we should probably just deprecate trio.testing.assert_no_yields entirely, with no replacement. I've never found a use for it, and can't think of any either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment