New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when used with Raven. #599

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@miracle2k
Contributor

miracle2k commented Aug 13, 2018

See #469.

@Zac-HD

Zac-HD approved these changes Aug 13, 2018

@njsmith

This comment has been minimized.

Member

njsmith commented Aug 13, 2018

Looks like you need to run yapf.

Can you throw in an entry in newsfragments/ too?

@miracle2k miracle2k force-pushed the miracle2k:raven-fix branch from f827415 to 1c4b63f Aug 13, 2018

@miracle2k

This comment has been minimized.

Contributor

miracle2k commented Aug 13, 2018

CI pass!

@njsmith njsmith merged commit c6309c1 into python-trio:master Aug 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov

This comment has been minimized.

codecov bot commented Aug 13, 2018

Codecov Report

Merging #599 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
- Coverage   99.31%   99.31%   -0.01%     
==========================================
  Files          91       91              
  Lines       10823    10822       -1     
  Branches      753      753              
==========================================
- Hits        10749    10748       -1     
  Misses         56       56              
  Partials       18       18
Impacted Files Coverage Δ
trio/_core/_ki.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6616c...1c4b63f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment