New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out all the old deprecated stuff. #623

Merged
merged 5 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@Fuyukai
Contributor

Fuyukai commented Aug 23, 2018

No description provided.

Fuyukai added some commits Aug 23, 2018

@codecov

This comment has been minimized.

codecov bot commented Aug 23, 2018

Codecov Report

Merging #623 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #623      +/-   ##
=========================================
- Coverage   99.31%   99.3%   -0.02%     
=========================================
  Files          91      91              
  Lines       10873   10752     -121     
  Branches      758     758              
=========================================
- Hits        10799   10677     -122     
- Misses         56      57       +1     
  Partials       18      18
Impacted Files Coverage Δ
trio/_socket.py 100% <ø> (ø) ⬆️
trio/_core/tests/test_local.py 100% <ø> (ø) ⬆️
trio/_toplevel_core_reexports.py 100% <ø> (ø) ⬆️
trio/hazmat.py 100% <ø> (ø) ⬆️
trio/_core/_run.py 100% <ø> (ø) ⬆️
trio/tests/test_socket.py 100% <ø> (ø) ⬆️
trio/_core/_local.py 100% <100%> (ø) ⬆️
trio/_core/_ki.py 98.38% <0%> (-1.62%) ⬇️
trio/tests/test_signals.py 100% <0%> (ø) ⬆️
trio/_sync.py 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0dd7d...deb42e6. Read the comment docs.

@njsmith

This comment has been minimized.

Member

njsmith commented Aug 23, 2018

Can you throw in a newsfragment? Can be simple, just 623.removal.rst and something like "Removed all APIs that were deprecated in v0.4.0 or earlier." (Assuming that's true, I haven't checked :-).)

This will also trigger jenkins to re-run and hopefully clear the transient failure...

@njsmith

This comment has been minimized.

Member

njsmith commented Aug 23, 2018

Ah, codecov is actually useful this time! It looks like there's still some task-local related code left behind in _run.py: https://codecov.io/gh/python-trio/trio/pull/623/src/trio/_core/_run.py

I guess we should get rid of the Task._locals attribute entirely.

@njsmith

This comment has been minimized.

Member

njsmith commented Aug 24, 2018

Thanks!

@njsmith njsmith merged commit 2c4dbf5 into python-trio:master Aug 24, 2018

5 checks passed

codecov/patch 100% of diff hit (target 99.31%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +0.68% compared to 7f0dd7d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment