Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support renaming custom classes #49

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@sethmlarson
Copy link
Contributor

sethmlarson commented Dec 9, 2019

Adds support for having custom classes named AsyncXYZ and they will be renamed to SyncXYZ. Also adds more type hints so that this new class name functionality doesn't break those type annotations.

This version of unasync works for the high-level Hip branch.

Copy link
Member

pquentin left a comment

Thanks! Looks like we need to remove Python 3.4 (and add 3.8?) first.

@sethmlarson

This comment has been minimized.

Copy link
Contributor Author

sethmlarson commented Dec 10, 2019

I'll open a PR for that as well.

@pquentin

This comment has been minimized.

Copy link
Member

pquentin commented Dec 10, 2019

Closing/reopening to see if the builds pick up the fix in master.

@pquentin pquentin closed this Dec 10, 2019
@pquentin pquentin reopened this Dec 10, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #49 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   96.42%   96.55%   +0.12%     
==========================================
  Files           4        4              
  Lines         168      174       +6     
  Branches       40       44       +4     
==========================================
+ Hits          162      168       +6     
  Misses          2        2              
  Partials        4        4
Impacted Files Coverage Δ
src/unasync/__init__.py 96.51% <100%> (+0.12%) ⬆️
unasync/__init__.py 96.51% <0%> (+0.12%) ⬆️
@pquentin pquentin merged commit 4c4bf5e into python-trio:master Dec 10, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 96.42%)
Details
codecov/project 96.55% (+0.12%) compared to d8478db
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@pquentin

This comment has been minimized.

Copy link
Member

pquentin commented Dec 10, 2019

Thank you @sethmlarson!

@sethmlarson sethmlarson deleted the sethmlarson:class-renaming branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.