Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check news will pass as long as the file is not empty. #152

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@Mariatta
Copy link
Member

Mariatta commented Feb 11, 2019

From discussions in python/cpython#11779 (comment), it was determined that the check news status should pass as long as the news file is not empty. cc @ned-deily

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #152   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1530   1530           
  Branches       86     86           
=====================================
  Hits         1530   1530
Impacted Files Coverage Δ
tests/test_news.py 100% <100%> (ø) ⬆️
bedevere/news.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8dcca...b458feb. Read the comment docs.

@Mariatta Mariatta merged commit 5549b9f into python:master Feb 12, 2019

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to ca8dcca
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mariatta Mariatta deleted the Mariatta:check-news-not-empty branch Feb 12, 2019

@ned-deily

This comment has been minimized.

Copy link
Member

ned-deily commented Feb 12, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.