Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create "needs backport to" label when maintenance branch created. #174

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Mariatta
Copy link
Member

commented Jun 4, 2019

Creating label is boring. With this PR, bedevere will automatically
create the needs backport to label when a maintenance branch
is created under CPython repo.

Maintenance branch has the pattern: 3.9, 4.0, 3.10, ...

  • enable the Branch or Tag creation webhook in CPython.
Automatically create "needs backport to" label when maintenance branc…
…h created.

Creating label is boring. With this PR, bedevere will automatically
create the `needs backport to ` label when a maintenance branch
is created under CPython repo.

Maintenance branch has the pattern: 3.9, 4.0, 3.10, ...
@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #174   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1534   1558   +24     
  Branches       86     87    +1     
=====================================
+ Hits         1534   1558   +24
Impacted Files Coverage Δ
bedevere/backport.py 100% <100%> (ø) ⬆️
tests/test_backport.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5103b98...37cb3a5. Read the comment docs.

@bsipocz

This comment has been minimized.

Copy link

commented Jun 4, 2019

👋 @Mariatta - I'm sure your procedures are very much different than ours (we don't use bots to backport, but do everything manually (technically)). Rather we use a bunch of scripts that generates a copy paste-able list to cherry-pick/backport.

Maybe some of the logic can be reused:
https://github.com/astropy/astropy-procedures/tree/master/pr_consistency

@@ -346,3 +346,32 @@ def __init__(self, *, getitem=None, delete=None, post=None):
gh = FakeGH(getitem=getitem)
await backport.router.dispatch(event, gh)
assert len(gh.post_) == 0


@pytest.mark.parametrize('ref', ['3.9', '4.0', '3.10'])

This comment has been minimized.

Copy link
@terryjreedy

terryjreedy Jun 5, 2019

Member

There is no current plan for 4.0, certainly not 4.0 and 3.10. I believe a majority agreed on 3.10 instead of 4.0, but a few seem to support 4.0 rather than 3.10. We probably should revisit this soon.

This comment has been minimized.

Copy link
@Mariatta

Mariatta Jun 5, 2019

Author Member

4.0 is still a valid test case.

@Mariatta

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

PR updated. It will also create an issue in https://github.com/berkerpeksag/cpython-emailer-webhook/ to remind people about adding the new maintenance branch to the list of ALLOWED_BRANCHES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.