-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new "type" labels after GH migration. #419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1298 1300 +2
=========================================
+ Hits 1298 1300 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do you think there's any downside applying it now or is it better/safer to wait? I can still update the labels on my end so that they match the new labels during the migration.
On a more general note, many of the new labels are related to specific dirs/files in the repo, so bevedere will probably need some refactoring so that it can add more labels (also because docs
, performance
, tests
are no longer types).
I would suggest changing the labels first on the CPython repo, and then deploy bedevere afterwards (by merging this PR). |
That makes sense, should we do it now? |
Yup let's do it! |
Thanks for the PR! |
Closes python/core-workflow#432