Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new "type" labels after GH migration. #419

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

Mariatta
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #419 (4fd479a) into master (3d532cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1298      1300    +2     
=========================================
+ Hits          1298      1300    +2     
Impacted Files Coverage Δ
tests/test_filepaths.py 100.00% <100.00%> (ø)
tests/test_prtype.py 100.00% <100.00%> (ø)

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you think there's any downside applying it now or is it better/safer to wait? I can still update the labels on my end so that they match the new labels during the migration.

On a more general note, many of the new labels are related to specific dirs/files in the repo, so bevedere will probably need some refactoring so that it can add more labels (also because docs, performance, tests are no longer types).

bedevere/prtype.py Show resolved Hide resolved
@Mariatta
Copy link
Member Author

I would suggest changing the labels first on the CPython repo, and then deploy bedevere afterwards (by merging this PR).

@ezio-melotti
Copy link
Member

That makes sense, should we do it now?

@Mariatta
Copy link
Member Author

Yup let's do it!

@ezio-melotti ezio-melotti merged commit 6f4978e into master Mar 25, 2022
@ezio-melotti
Copy link
Member

Thanks for the PR!
I renamed the labels on python/cpython and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming labels on python/cpython
3 participants