Move blurb to its own directory #139
Conversation
|
Uh, oops. I already moved blurb into its own directory, locally--in my rushing around yesterday I forgot to check it in and upload it. My copy is the basis of what's uploaded to the cheeseshop. Would it be okay if we started with my version instead? BTW, some changes to cherry-picker got mixed in to your branch. |
| :target: https://travis-ci.org/python/core-workflow | ||
|
|
||
| cherry_picker 🐍 🍒 ⛏ | ||
| ------------------------------- |
There was a problem hiding this comment.
Extra dashes here and in line 28 below.
There was a problem hiding this comment.
It doesn't matter; reST only cares that the dashes are at least as long the text; this makes sure that I don't have to care if any of those emojis are counted as more than a single letter by reST.
blurb/flit.ini
Outdated
| description-file = README.rst | ||
| classifiers = Intended Audience :: Developers | ||
| License :: OSI Approved :: BSD License | ||
| Programming Language :: Python :: 3 |
There was a problem hiding this comment.
Should it be specified that blurb uses Python 3.6? (f-strings)
There was a problem hiding this comment.
Sure, I just didn't bother to check blurb to see what version it was restricted to as that's what Larry specified on PyPI.
|
@larryhastings please check in your changes now then and I will tweak as necessary. And I know about the cherry_picker changes sneaking in as I only noticed them as I was fixing things in the README. |
|
Pushed. |
|
@larryhastings please have another look at the blurb-related changes (I stuck with flit over setuptools since it's just so much easier to work with). |
| @@ -1,2 +0,0 @@ | |||
| include LICENSE.txt | |||
| include README.rst | |||
There was a problem hiding this comment.
I added LICENSE.txt and README.rst to the manifest because at one point when I was packaging it complained it didn't have README.rst in the package. I don't know proper MANIFEST.in hygiene, but--why shouldn't they be listed here?
There was a problem hiding this comment.
Flit uses what's committed in the VCS to determine what goes into the sdist, not the MANIFEST.in file. So basically the file is redundant by moving to flit (which is one of the nice things about the utility).
blurb/blurb.py
Outdated
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env python3 | |||
| """ommand-line tool to manage CPython Misc/NEWS.d entries.""" | |||
There was a problem hiding this comment.
Missing the first letter, the 'C' in 'Command'
blurb/flit.ini
Outdated
| maintainer = Python Core Developers | ||
| maintainer-email = core-workflow@mail.python.org | ||
| home-page = https://github.com/python/core-workflow/tree/master/blurb | ||
| requires-python = >=3 |
|
LGTM |
Also set it up for easy uploading to PyPI using flit.