Skip to content
Permalink
Browse files

bpo-34279: regrtest consider that skipped tests are ran (GH-11132) (G…

…H-11158)

bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.

(cherry picked from commit 3a8f4fe)
  • Loading branch information...
vstinner committed Dec 14, 2018
1 parent 16d6320 commit 34b7c438b8dc0a1e7e23c9b2d7ce7f8a7c31b4f4
@@ -1543,7 +1543,7 @@ def _run_suite(suite):
runner = BasicTestRunner()

result = runner.run(suite)
if not result.testsRun:
if not result.testsRun and not result.skipped:
raise TestDidNotRun
if not result.wasSuccessful():
if len(result.errors) == 1 and not result.failures:
@@ -734,6 +734,19 @@ def test_main():
output = self.run_tests("-m", "nosuchtest", testname, exitcode=0)
self.check_executed_tests(output, [testname], no_test_ran=testname)

def test_no_tests_ran_skip(self):
code = textwrap.dedent("""
import unittest
class Tests(unittest.TestCase):
def test_skipped(self):
self.skipTest("because")
""")
testname = self.create_test(code=code)

output = self.run_tests(testname, exitcode=0)
self.check_executed_tests(output, [testname])

def test_no_tests_ran_multiple_tests_nonexistent(self):
code = textwrap.dedent("""
import unittest
@@ -0,0 +1,3 @@
:func:`test.support.run_unittest` no longer raise :exc:`TestDidNotRun` if
the test result contains skipped tests. The exception is now only raised if
no test have been run and no test have been skipped.

0 comments on commit 34b7c43

Please sign in to comment.
You can’t perform that action at this time.