Skip to content

Commit

Permalink
bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (
Browse files Browse the repository at this point in the history
  • Loading branch information
lysnikolaou authored and ned-deily committed Nov 4, 2018
1 parent c03bf0a commit 59668aa
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Lib/test/test_gdb.py
Expand Up @@ -5,6 +5,7 @@

import locale
import os
import platform
import re
import subprocess
import sys
Expand Down Expand Up @@ -48,6 +49,10 @@ def get_gdb_version():
if not sysconfig.is_python_build():
raise unittest.SkipTest("test_gdb only works on source builds at the moment.")

if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
" built with LLVM clang")

# Location of custom hooks file in a repository checkout.
checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
'python-gdb.py')
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
Expand Up @@ -1147,6 +1147,7 @@ Samuel Nicolary
Jonathan Niehof
Gustavo Niemeyer
Oscar Nierstrasz
Lysandros Nikolaou
Hrvoje Nikšić
Gregory Nofi
Jesse Noller
Expand Down
@@ -0,0 +1,4 @@
After several reports that test_gdb does not work properly on macOS and
since gdb is not shipped by default anymore, test_gdb is now skipped on
macOS when LLVM Clang has been used to compile Python. Patch by
Lysandros Nikolaou

0 comments on commit 59668aa

Please sign in to comment.