Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
bpo-32101: Fix tests for PYTHONDEVMODE=1 (#4821)
test_asycio: remove also aio_path which was used when asyncio was
developed outside the stdlib.
  • Loading branch information
vstinner committed Dec 12, 2017
1 parent 747f48e commit 721e25c
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 17 deletions.
7 changes: 5 additions & 2 deletions Lib/test/test_asyncio/test_base_events.py
Expand Up @@ -802,17 +802,20 @@ def test_env_var_debug(self):
self.assertEqual(stdout.rstrip(), b'False')

sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='')
PYTHONASYNCIODEBUG='',
PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')

sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='1')
PYTHONASYNCIODEBUG='1',
PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'True')

sts, stdout, stderr = assert_python_ok('-E', '-c', code,
PYTHONASYNCIODEBUG='1')
self.assertEqual(stdout.rstrip(), b'False')

# -X dev
sts, stdout, stderr = assert_python_ok('-E', '-X', 'dev',
'-c', code)
self.assertEqual(stdout.rstrip(), b'True')
Expand Down
12 changes: 5 additions & 7 deletions Lib/test/test_asyncio/test_tasks.py
Expand Up @@ -2257,33 +2257,31 @@ def test_return_exceptions(self):
self.assertEqual(fut.result(), [3, 1, exc, exc2])

def test_env_var_debug(self):
aio_path = os.path.dirname(os.path.dirname(asyncio.__file__))

code = '\n'.join((
'import asyncio.coroutines',
'print(asyncio.coroutines._DEBUG)'))

# Test with -E to not fail if the unit test was run with
# PYTHONASYNCIODEBUG set to a non-empty string
sts, stdout, stderr = assert_python_ok('-E', '-c', code,
PYTHONPATH=aio_path)
sts, stdout, stderr = assert_python_ok('-E', '-c', code)
self.assertEqual(stdout.rstrip(), b'False')

sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='',
PYTHONPATH=aio_path)
PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')

sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='1',
PYTHONPATH=aio_path)
PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'True')

sts, stdout, stderr = assert_python_ok('-E', '-c', code,
PYTHONASYNCIODEBUG='1',
PYTHONPATH=aio_path)
PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')

# -X dev
sts, stdout, stderr = assert_python_ok('-E', '-X', 'dev',
'-c', code)
self.assertEqual(stdout.rstrip(), b'True')
Expand Down
14 changes: 6 additions & 8 deletions Lib/test/test_faulthandler.py
Expand Up @@ -332,13 +332,9 @@ def test_is_enabled(self):
def test_disabled_by_default(self):
# By default, the module should be disabled
code = "import faulthandler; print(faulthandler.is_enabled())"
args = filter(None, (sys.executable,
"-E" if sys.flags.ignore_environment else "",
"-c", code))
env = os.environ.copy()
env.pop("PYTHONFAULTHANDLER", None)
args = (sys.executable, "-E", "-c", code)
# don't use assert_python_ok() because it always enables faulthandler
output = subprocess.check_output(args, env=env)
output = subprocess.check_output(args)
self.assertEqual(output.rstrip(), b"False")

def test_sys_xoptions(self):
Expand All @@ -357,15 +353,17 @@ def test_env_var(self):
# empty env var
code = "import faulthandler; print(faulthandler.is_enabled())"
args = (sys.executable, "-c", code)
env = os.environ.copy()
env = dict(os.environ)
env['PYTHONFAULTHANDLER'] = ''
env['PYTHONDEVMODE'] = ''
# don't use assert_python_ok() because it always enables faulthandler
output = subprocess.check_output(args, env=env)
self.assertEqual(output.rstrip(), b"False")

# non-empty env var
env = os.environ.copy()
env = dict(os.environ)
env['PYTHONFAULTHANDLER'] = '1'
env['PYTHONDEVMODE'] = ''
output = subprocess.check_output(args, env=env)
self.assertEqual(output.rstrip(), b"True")

Expand Down

0 comments on commit 721e25c

Please sign in to comment.