Skip to content
Permalink
Browse files

bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…

…Is [streams] (GH-13671)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Second step: streams.py

https://bugs.python.org/issue36373
(cherry picked from commit 6d64a8f)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
  • Loading branch information...
miss-islington and eamanu committed Jun 5, 2019
1 parent 39346ff commit 8899b11b95f08e2e03478f2acad336ad5933a2d1
Showing with 16 additions and 0 deletions.
  1. +16 −0 Lib/asyncio/streams.py
@@ -175,6 +175,10 @@ def connect_write_pipe(pipe, *, limit=_DEFAULT_LIMIT):
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
reader = StreamReader(limit=limit, loop=loop)
protocol = StreamReaderProtocol(reader, loop=loop, _asyncio_internal=True)
transport, _ = await loop.create_connection(
@@ -213,6 +217,10 @@ def connect_write_pipe(pipe, *, limit=_DEFAULT_LIMIT):
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

def factory():
reader = StreamReader(limit=limit, loop=loop)
@@ -414,6 +422,10 @@ def factory():
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
reader = StreamReader(limit=limit, loop=loop)
protocol = StreamReaderProtocol(reader, loop=loop,
_asyncio_internal=True)
@@ -473,6 +485,10 @@ def connect_unix(path=None, *,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

def factory():
reader = StreamReader(limit=limit, loop=loop)

0 comments on commit 8899b11

Please sign in to comment.
You can’t perform that action at this time.