Permalink
Browse files

Fix #29519: weakref spewing exceptions during interp finalization

  • Loading branch information...
ambv committed Feb 10, 2017
1 parent e662445 commit 9cd7e17640a49635d1c1f8c2989578a8fc2c1de6
Showing with 5 additions and 2 deletions.
  1. +2 −2 Lib/weakref.py
  2. +3 −0 Misc/NEWS
@@ -106,15 +106,15 @@ def __init__(*args, **kw):
self, *args = args
if len(args) > 1:
raise TypeError('expected at most 1 arguments, got %d' % len(args))
def remove(wr, selfref=ref(self)):
def remove(wr, selfref=ref(self), _atomic_removal=_remove_dead_weakref):
self = selfref()
if self is not None:
if self._iterating:
self._pending_removals.append(wr.key)
else:
# Atomic removal is necessary since this function
# can be called asynchronously by the GC
_remove_dead_weakref(d, wr.key)
_atomic_removal(d, wr.key)
self._remove = remove
# A list of keys to be removed
self._pending_removals = []
@@ -23,6 +23,9 @@ Extension Modules
Library
-------

- Issue #29519: Fix weakref spewing exceptions during interpreter shutdown
when used with a rare combination of multiprocessing and custom codecs.

- Issue #29416: Prevent infinite loop in pathlib.Path.mkdir

- Issue #29444: Fixed out-of-bounds buffer access in the group() method of

0 comments on commit 9cd7e17

Please sign in to comment.