Skip to content

Commit

Permalink
bpo-13886: Skip PTY non-ASCII tests if readline is loaded (GH-30631)
Browse files Browse the repository at this point in the history
Skip test_builtin PTY tests on non-ASCII characters if the readline
module is loaded. The readline module changes input() behavior, but
test_builtin is not intented to test the readline module.

When the readline module is loaded, PyOS_Readline() uses the readline
implementation. In some cases, the Python readline callback
rlhandler() is called by readline with a string without non-ASCII
characters.
  • Loading branch information
vstinner committed Jan 17, 2022
1 parent 42a64c0 commit ad6e640
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
16 changes: 14 additions & 2 deletions Lib/test/test_builtin.py
Expand Up @@ -2090,12 +2090,24 @@ def test_input_tty(self):
# is different and invokes GNU readline if available).
self.check_input_tty("prompt", b"quux")

def skip_if_readline(self):
# bpo-13886: When the readline module is loaded, PyOS_Readline() uses
# the readline implementation. In some cases, the Python readline
# callback rlhandler() is called by readline with a string without
# non-ASCII characters. Skip tests on non-ASCII characters if the
# readline module is loaded, since test_builtin is not intented to test
# the readline module, but the builtins module.
if 'readline' in sys.modules:
self.skipTest("the readline module is loaded")

def test_input_tty_non_ascii(self):
# Check stdin/stdout encoding is used when invoking GNU readline
self.skip_if_readline()
# Check stdin/stdout encoding is used when invoking PyOS_Readline()
self.check_input_tty("prompté", b"quux\xe9", "utf-8")

def test_input_tty_non_ascii_unicode_errors(self):
# Check stdin/stdout error handler is used when invoking GNU readline
self.skip_if_readline()
# Check stdin/stdout error handler is used when invoking PyOS_Readline()
self.check_input_tty("prompté", b"quux\xe9", "ascii")

def test_input_no_stdout_fileno(self):
Expand Down
@@ -0,0 +1,3 @@
Skip test_builtin PTY tests on non-ASCII characters if the readline module
is loaded. The readline module changes input() behavior, but test_builtin is
not intented to test the readline module. Patch by Victor Stinner.

0 comments on commit ad6e640

Please sign in to comment.